[Okular-devel] Review Request 109625: Do not re-show tool name in continuous annotation mode

Albert Astals Cid aacid at kde.org
Thu Mar 21 19:31:50 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109625/#review29655
-----------------------------------------------------------

Ship it!


Looks good

- Albert Astals Cid


On March 21, 2013, 12:38 a.m., Peter Grasch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109625/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 12:38 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Right now, the name of the selected annotation tool is re-shown for every stroke in continuous mode.
> 
> This was probably just an artifact of the implementation but it's IMHO nicer to just show the tool name once.
> 
> 
> Diffs
> -----
> 
>   ui/pageviewannotator.cpp 7bd7496 
> 
> Diff: http://git.reviewboard.kde.org/r/109625/diff/
> 
> 
> Testing
> -------
> 
> Local tests show expected behavior.
> 
> 
> Thanks,
> 
> Peter Grasch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130321/33faa170/attachment.html>


More information about the Okular-devel mailing list