[Okular-devel] Review Request 108614: Open url in browser

[Jaydeep Solanki]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
-----------------------------------------------------------

(Updated March 13, 2013, 2:28 p.m.)


Review request for Okular.


Changes
-------

a unit test added.
BTW, can I add that banner( that is on top of every file containing copyright ), with my name ?


Description
-------

When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser.

pdf with links update : http://goo.gl/wBM6p


This addresses bug 281027.
    http://bugs.kde.org/show_bug.cgi?id=281027


Diffs (updated)
-----

  ui/pageview.cpp b018dfe 
  tests/urldetecttest.cpp PRE-CREATION 
  tests/CMakeLists.txt 6a26b3e 
  ui/url_utils.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/108614/diff/


Testing
-------

just check if the icon appears properly, because I have an issue with the icon.


Thanks,

Jaydeep Solanki

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130313/0046202d/attachment.html>