[Okular-devel] Review Request 107442: Add undo/redo support for annotations

[Jon Mease]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107442/
-----------------------------------------------------------

(Updated March 12, 2013, 1:24 a.m.)


Review request for Okular.


Changes
-------

Updates based on Albert's review of version 5 of the patch.


Description (updated)
-------

This patch adds undo/redo support to Okular annotation manipulation commands.

Functionality:
The following actions can be undone and redone: creation and removal of annotations, editing arbitrary annotation properties, relocating annotations with Ctrl+drag, and editing the text contents of an annotation.

This patch does not include support for undoing and redoing editing actions on forms.

  


This addresses bug 177501.
    http://bugs.kde.org/show_bug.cgi?id=177501


Diffs (updated)
-----

  core/annotations.h 72abdff 
  core/annotations.cpp 49ab5bd 
  core/annotations_p.h 221572d 
  core/document.h 6ff6536 
  core/document.cpp 5ab759e 
  core/document_p.h fb3aec6 
  core/page.cpp 1db2763 
  part.rc 39c1571 
  ui/annotationpropertiesdialog.cpp 4b02258 
  ui/annotwindow.h f7df9f6 
  ui/annotwindow.cpp c1bafb9 
  ui/pageview.cpp b018dfe 

Diff: http://git.reviewboard.kde.org/r/107442/diff/


Testing
-------

I have tested the undoing and redoing of the specified annotation actions using .dvi and .pdf documents.  The only known issue is the one described above when using .pdf files. 


Thanks,

Jon Mease

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130312/8a54e738/attachment.html>