[Okular-devel] Review Request 103060: Implement the handling of page rotations for source references

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103060/#review28844
-----------------------------------------------------------


Michel, do you think you could have a look at the tests/ folder and try to come up with something that exercises this patch to prove it works? I'd be much happier with a unit test, since i have to be honest i am not really sure what we are trying to achieve here so if in the future it breaks having a unittest will be much easier to bring back the expected feature :-)

- Albert Astals Cid


On Feb. 2, 2013, 8:47 p.m., Michel Ludwig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103060/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2013, 8:47 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Implement the handling of page rotations for source references.
> 
> 
> Diffs
> -----
> 
>   core/document.h 1d825e1 
>   core/document.cpp 372af56 
>   core/page.h 6bc60c5 
>   core/page.cpp 4df58e0 
>   core/utils.h 8d5d5fc 
>   core/utils.cpp 5dd8448 
>   generators/dvi/generator_dvi.cpp c666933 
>   generators/poppler/generator_pdf.cpp 0b2c253 
>   part.cpp f1cdc11 
>   ui/pagepainter.cpp 91ae211 
>   ui/pageview.h d8a7653 
>   ui/pageview.cpp 60a273d 
>   ui/side_reviews.cpp a35f9ed 
>   ui/thumbnaillist.cpp 33a5431 
> 
> Diff: http://git.reviewboard.kde.org/r/103060/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Example LaTeX File
>   http://git.reviewboard.kde.org/media/uploaded/files/2011/11/08/test.tex
> Example PDF File
>   http://git.reviewboard.kde.org/media/uploaded/files/2011/11/08/test.pdf
> Example SyncTeX File
>   http://git.reviewboard.kde.org/media/uploaded/files/2011/11/08/test.synctex.gz
> 
> 
> Thanks,
> 
> Michel Ludwig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130309/0238cbb0/attachment-0001.html>