[Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109364/#review28843
-----------------------------------------------------------


I am not sure this is the totally correct fix (I'm not saying the code we have now is better). But i do have here epubs that set the color of the text to black  ( e.g http://bugs.kde.org/attachment.cgi?id=51488 ), so in case my i would get black on black :-/

On the other hand i see the problem the reporter is having.

OTOH in further inspection of http://bugs.kde.org/attachment.cgi?id=51488 seems it is declaring it wants its background to be white, wonder why we are not getting it white then :S

Do yo have time to investigate why this is happening? Because it we commit this patch directly i feel it would be going from one bug to another, and not sure it makes much sense

- Albert Astals Cid


On March 8, 2013, 11:38 p.m., Azat Khuzhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109364/
> -----------------------------------------------------------
> 
> (Updated March 8, 2013, 11:38 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Instead of just force it to white.
>     
> This must fix bug 306572.
> https://bugs.kde.org/show_bug.cgi?id=306572
> 
> 
> This addresses bug 306572.
>     http://bugs.kde.org/show_bug.cgi?id=306572
> 
> 
> Diffs
> -----
> 
>   core/textdocumentgenerator.cpp f370ded 
> 
> Diff: http://git.reviewboard.kde.org/r/109364/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Azat Khuzhin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130309/216af5fd/attachment.html>