[Okular-devel] Review Request 109096: Open print dialog from command line

[Tomáš Poledný]

> On Feb. 28, 2013, 11:45 p.m., Albert Astals Cid wrote:
> > kdocumentviewer.h, line 50
> > <http://git.reviewboard.kde.org/r/109096/diff/4/?file=116181#file116181line50>
> >
> >     Do we need this? If not i'd prefer not to change this public header.

Yes, it is like startPresentation. I was thinking start presentation is similar action to printing. That is reason why I changed this interface. Or we can cast m_part to Part (Okular). What is better for you?


> On Feb. 28, 2013, 11:45 p.m., Albert Astals Cid wrote:
> > part.h, line 152
> > <http://git.reviewboard.kde.org/r/109096/diff/4/?file=116182#file116182line152>
> >
> >     Why do we need enableStartPrint and startPrint if they do the same?

You are right but enableStartPrint is method for D-Bus calling. startPrint is inherited from interface. It's the same question. Is printing action similar to a presentation or not? If not we can cast m_part and use only enableStartPrint and remove startPrint from interface. What is better choice for you?


- Tomáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109096/#review28312
-----------------------------------------------------------


On Feb. 27, 2013, 11:58 p.m., Tomáš Poledný wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109096/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2013, 11:58 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Added command line options print. Bug 252462
> 
> 
> This addresses bug 252462.
>     http://bugs.kde.org/show_bug.cgi?id=252462
> 
> 
> Diffs
> -----
> 
>   kdocumentviewer.h 2f77610 
>   part.h 2fcdf0a 
>   part.cpp 912716a 
>   shell/main.cpp 226dab8 
>   shell/shell.cpp 81d63c2 
> 
> Diff: http://git.reviewboard.kde.org/r/109096/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomáš Poledný
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130301/bc3b4518/attachment-0001.html>