[Okular-devel] Branch 'epub-qtextdoc' review

[Fabio D'Urso]

On Monday, June 24, 2013 11:57:35 PM Jaydeep Solanki wrote:
> Hello,
> I have put together some of my work, in a branch named 'epub-qtextdoc'.
> 
> It would be really nice if you can review it.

Hi Jaydeep,

I've never worked on epubs, therefore I can't really comment on your code.

I noticed that there are some indentation changes in your patch "epub change 
document loading method" that affect code that would otherwise be unaffected.
Such changes make diffs unnecessarily long and harder to read, because it's 
not clear what code has been changed or not (and they also confuse git's 
history tracking).

Sorry again for not being able to review the actual code,

Fabio