[Okular-devel] Review Request 111138: Make TextDocument_Generator Threaded

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111138/#review34710
-----------------------------------------------------------


This looks ok, i'll try to have a better look tomorrow, but it also means that we should "ignore" the greedy mode for non threaded generators

Also if we are happy with the code i think i'll just remove the ifdefs, but let me have a more indepth look tomorrow

- Albert Astals Cid


On June 19, 2013, 7:26 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111138/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 7:26 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> If Okular is set to Greedy Performance;
> 
> [Current scenario]:
> Opening a TextDocument based format will be displayed only after all the pages have been loaded.
> 
> [Expected result]:
> Okular should open(display) the document and then keep load remaining pages.
> 
> 
> PS : I chose to clone QTextDocument because it took less time than drawingContent.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 217337f 
>   core/textdocumentgenerator.cpp b260b3f 
> 
> Diff: http://git.reviewboard.kde.org/r/111138/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130619/0416e639/attachment.html>