[Okular-devel] [okular] [Bug 268757] [Patch] Constant DPI in PDF backend results in incorrect size of pages on screen

[Eugene Shalygin]

https://bugs.kde.org/show_bug.cgi?id=268757

--- Comment #17 from Eugene Shalygin <eugene.shalygin+bugzilla.kde at gmail.com> ---
Dear Albert,

I would like to return to this problem and finally push it to the finish. Since
physical DPI grows so quickly, the problem becomes more and more prominent. For
example, my wife already refuses to use Okular because of that.

I decided to use LibKScreen instead of pure XRandr (that gives a possibility to
handle other desktop servers, what do you think? Is it better than XRand?). So
I added screen size in millimetres to it and calculation of DPI on the base of
LibKScreen data in Utils::realDpi().

However, the DPI depends on QWidget used to draw on, therefore now one needs to
pass this widget into generators. As for me, the widget has to be passed in
Generator::generatePixmap() call. And here I can not decide how to do that.
Should it be added to PixmapRequest class? Or to the Page class? I'm afraid
that I do not understand design of Okular wee enough to make this decision.
Could you, please, help me?

-- 
You are receiving this mail because:
You are the assignee for the bug.