[Okular-devel] Review Request 111793: kimgio generator: Apply transformations dictated by Exif metadata
Fabio D'Urso
fabiodurso at hotmail.it
Tue Jul 30 09:40:41 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111793/
-----------------------------------------------------------
Review request for Okular.
Description
-------
This patch fixes bug 322920 (JPG images don't open rotated correctly).
It adds a dependency on libKExiv2, which is a wrapper around Exiv2.
I've put the code that applies the transformation in loadDocument(), which means that it will block the UI.
Of course, with a little more effort, it can be moved to image(), but I've decided to keep it in loadDocument() because:
- it's a one-time only operation;
- loadDocument() already blocks while loading the file, so I guess a little more time won't hurt much.
Of course, if you don't agree, I can change it.
The dependency on libKExiv2 *not* optional because I want to avoid having orientation depend on compilation flags. If I made it optional and you shared a .okular archive with annotations, their (normalized) coordinates would no longer be consistent among clients.
This addresses bug 322920.
http://bugs.kde.org/show_bug.cgi?id=322920
Diffs
-----
generators/kimgio/CMakeLists.txt b0a61eb
generators/kimgio/generator_kimgio.cpp 1badab3
Diff: http://git.reviewboard.kde.org/r/111793/diff/
Testing
-------
- Image from bug 322920
- Images taken with my phone (Galaxy S2)
- Images without Exif metadata at all, to verify that they still work
Thanks,
Fabio D'Urso
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130730/19091ed4/attachment.html>
More information about the Okular-devel
mailing list