[Okular-devel] Review Request 111640: Remove Magic Stuff from Epub Generator

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111640/#review36468
-----------------------------------------------------------


You have your own branch, there is no need for you to ask for review for changes that go into your own branch.

If you have any question over a specific bit of code, ask it on the mailing list, but it's not the point of GSoC that you ask for a review of every 5 lines changes you make.

- Albert Astals Cid


On July 24, 2013, 5:01 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111640/
> -----------------------------------------------------------
> 
> (Updated July 24, 2013, 5:01 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Guess this is more proper implementation.
> 
> 
> Diffs
> -----
> 
>   generators/epub/converter.h 969dc9f 
>   generators/epub/converter.cpp 74df151 
>   generators/epub/epubdocument.h 714ede6 
>   generators/epub/epubdocument.cpp ae19f8a 
> 
> Diff: http://git.reviewboard.kde.org/r/111640/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130724/7189227a/attachment.html>