[Okular-devel] Review Request 111554: SVG support for Epubs

Jaydeep Solanki jaydp17 at gmail.com
Mon Jul 22 11:30:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111554/
-----------------------------------------------------------

(Updated July 22, 2013, 11:30 a.m.)


Review request for Okular.


Changes
-------

Now we don't need that mysterious 42.


Description
-------

Epubs use the below syntax to load svg images

<svg>
<image width="592" height="900" xlink:href="images/cover.svg" />
</svg>

I just replace that with <img> tags & add QImage as a resource.


Diffs (updated)
-----

  generators/epub/CMakeLists.txt 9442f61 
  generators/epub/converter.cpp 74df151 
  generators/epub/epubdocument.h 714ede6 

Diff: http://git.reviewboard.kde.org/r/111554/diff/


Testing
-------

The below link contains two epub files having svg images as cover.
https://www.dropbox.com/sh/xcqfwn8khbqac0d/vDRuFRw9vq


Thanks,

Jaydeep Solanki

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130722/af3b0a52/attachment-0001.html>


More information about the Okular-devel mailing list