[Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)

Albert Astals Cid aacid at kde.org
Sun Jul 21 15:36:56 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109364/
-----------------------------------------------------------

(Updated July 21, 2013, 3:36 p.m.)


Review request for Okular and Jaydeep Solanki.


Changes
-------

Guys, what do you think about adding background to basic text document settings,
get default from kde settings, and let users to change it in per-backend options.

And what for epub documents, I think that this must be in another patch.


Summary (updated)
-----------------

Get background color from KColorScheme (kde system settings)


Description
-------

Instead of just force it to white.
    
This must fix bug 306572.
https://bugs.kde.org/show_bug.cgi?id=306572


This addresses bug 306572.
    http://bugs.kde.org/show_bug.cgi?id=306572


Diffs
-----

  core/textdocumentgenerator.cpp f370ded 

Diff: http://git.reviewboard.kde.org/r/109364/diff/


Testing
-------


Thanks,

Azat Khuzhin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130721/da87326e/attachment.html>


More information about the Okular-devel mailing list