[Okular-devel] Review Request 110003: Best-fit zoom

[Thomas Fischer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110003/
-----------------------------------------------------------

(Updated July 7, 2013, 11:04 p.m.)


Review request for Okular.


Changes
-------

The patch reflects two changes based on comments in the Forum. First, it renames the feature to "auto fit" which a majority of comments support as a better name than "best fit".
Second, I am trying to add "Auto Fit" as one of the default zoom settings in the configuration dialog. Although I was quite sure I did not miss a spot and the option turns up in the settings dialog, choosing "Auto Fit" does not get activated when restarting Okular. Any hints what goes wrong?


Description
-------

Attached patch implements best-fit zoom for Okular. It is a refined version of the patch submitted in bug report 249364, attachment 51069. The refinement addresses the scrollbar issues as observed in continuous view mode.


This addresses bug 249364.
    http://bugs.kde.org/show_bug.cgi?id=249364


Diffs (updated)
-----

  conf/dlggeneralbase.ui f2c9efd 
  conf/okular.kcfg 1e23d61 
  part.rc 64aeffb 
  ui/pageview.h 5484cc5 
  ui/pageview.cpp 16b00ab 

Diff: http://git.reviewboard.kde.org/r/110003/diff/


Testing
-------


Thanks,

Thomas Fischer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130707/be48a9fe/attachment-0001.html>