[Okular-devel] Review Request 107994: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review25408
-----------------------------------------------------------


Can you explain why the code is added? Because obviously the current description and summary are wrong, and this shows you should not have reused this review request and should have created a new one instead.

- Albert Astals Cid


On Jan. 13, 2013, 3:12 a.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 3:12 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This fix will preserve the state of the Table Of Content (toc) on document reload, but if the toc is edited/changed, then it will be restored to default (i.e. all nodes will be folded)
> 
> 
> This addresses bugs 312138, 313146 and 313147.
>     http://bugs.kde.org/show_bug.cgi?id=312138
>     http://bugs.kde.org/show_bug.cgi?id=313146
>     http://bugs.kde.org/show_bug.cgi?id=313147
> 
> 
> Diffs
> -----
> 
>   ui/toc.cpp c1659bd 
>   ui/tocmodel.h 42d6533 
>   ui/tocmodel.cpp 214a218 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> -------
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130113/136fadb4/attachment.html>