[Okular-devel] Review Request 109119: Txt backend: Drop detectEncoding method and just feed more data to KEncodingProber

[Azat Khuzhin]

> On Feb. 23, 2013, 6:51 p.m., Azat Khuzhin wrote:
> > generators/txt/document.cpp, line 69
> > <http://git.reviewboard.kde.org/r/109119/diff/1/?file=115130#file115130line69>
> >
> >     Maybe we must use `array.left( i )` here?
> >     And increment i += chunkSize before.
> 
> Albert Astals Cid wrote:
>     Seems to me you should actually kill the detectEncoding function so you use a single encoding detector all the time and just feed() it more data

Thanks! Fixed.


- Azat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109119/#review27938
-----------------------------------------------------------


On Feb. 25, 2013, 8:15 p.m., Azat Khuzhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109119/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 8:15 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Don't to extra job, when encoding is detected just return encoding.
> 
> 
> Diffs
> -----
> 
>   generators/txt/document.h 08babea 
>   generators/txt/document.cpp badb647 
> 
> Diff: http://git.reviewboard.kde.org/r/109119/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Azat Khuzhin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130225/7e7af99e/attachment.html>