[Okular-devel] Review Request 109096: Open print dialog from command line

[Tomáš Poledný]

> On Feb. 23, 2013, 12:16 p.m., Albert Astals Cid wrote:
> > shell/shell.cpp, line 182
> > <http://git.reviewboard.kde.org/r/109096/diff/1/?file=114956#file114956line182>
> >
> >     Using QueuedConnections is by default evil and you shouldn't use them unless strictly necessary. I guess you're using it to open the dialog after the document has been loaded. Can't you just achieve that calling slotPrint after openUrl?

You are right. I have fixed it in new diff.


- Tomáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109096/#review27925
-----------------------------------------------------------


On Feb. 23, 2013, 1:35 p.m., Tomáš Poledný wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109096/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2013, 1:35 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Added command line options print. Bug 252462
> 
> 
> This addresses bug 252462.
>     http://bugs.kde.org/show_bug.cgi?id=252462
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp 226dab8 
>   shell/shell.cpp 81d63c2 
> 
> Diff: http://git.reviewboard.kde.org/r/109096/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomáš Poledný
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130223/6ddfedcc/attachment-0001.html>