[Okular-devel] Review Request 109041: Change search highlight color

[Albert Astals Cid]

> On Feb. 19, 2013, 11:15 p.m., Albert Astals Cid wrote:
> > But annotation highlight color can be changed, so what's the point of this, if we are using colors it may conflict at some point, no?
> 
> Jaydeep Solanki wrote:
>     yes, you are absolutely correct, but suppose you have a pdf with a lot of annotations, in that case you'll have to change the color of all the annotations.
>     & Okular doesn't provide a convenient way of changing colors in bulk.
>     So the other way of doing this would be providing an option like "change default annotation color", that changes all the highlights to a specific color.

I disagree, I think the proper fix is making the "Search" be somewhat different to annotations, by e.g. having a border or something around them so you can easily see what is a search and what is an annotation even if both have exactly the same color.

Thoughts?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109041/#review27755
-----------------------------------------------------------


On Feb. 19, 2013, 12:45 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109041/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 12:45 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> change search highlight color, as the annotation highlight color is the same which makes it difficult to differentiate between them.
> 
> 
> This addresses bug 273968.
>     http://bugs.kde.org/show_bug.cgi?id=273968
> 
> 
> Diffs
> -----
> 
>   ui/findbar.cpp f00f883 
>   ui/presentationsearchbar.cpp 68c0128 
> 
> Diff: http://git.reviewboard.kde.org/r/109041/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130221/a5251184/attachment.html>