[Okular-devel] Review Request 108614: Open url in browser

[Albert Astals Cid]

> On Jan. 27, 2013, 7:02 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 2775
> > <http://git.reviewboard.kde.org/r/108614/diff/1/?file=109368#file109368line2775>
> >
> >     Why did you decide that icon name?
> 
> Jaydeep Solanki wrote:
>     I had two options for goto icon, "go_goto" & "go_goto_page" but none of them shows an icon.
>     I decided to keep, the later one because I have used it in one of my apps, & at that time it worked.
> 
> Albert Astals Cid wrote:
>     Use "kdialog --geticon foo", then select again the Actions combo (seems that's a bug) and once you are there try to look for an icon that makes sense, if not, i guess it's better to simply use no icon than one that doesn't exist
> 
> Jaydeep Solanki wrote:
>     Don't you think that the 'search for' option that appears when right clicked on selected text, should have 'edit-web-search' icon,
>     & go to 'link' should have 'preferences-web-browser-shortcuts'.
>     I just had a look at the icons & I think 'edit-web-search' describes the search action more appropriately.

I agree these icons look "good" in the current theme I am using but the names seem to say they are though for other actions, meaning in other theme or in the future they may chage and not be useful for us at all. I think i'd go with no icons for now.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review26271
-----------------------------------------------------------


On Feb. 17, 2013, 7:04 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108614/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2013, 7:04 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser.
> 
> 
> This addresses bug 281027.
>     http://bugs.kde.org/show_bug.cgi?id=281027
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 60a273d 
> 
> Diff: http://git.reviewboard.kde.org/r/108614/diff/
> 
> 
> Testing
> -------
> 
> just check if the icon appears properly, because I have an issue with the icon.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130219/45d8b23d/attachment.html>