[Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109021/#review27753
-----------------------------------------------------------



conf/dlggeneralbase.ui
<http://git.reviewboard.kde.org/r/109021/#comment20800>

    This is not strictly true, it also applies for epub, fictiobook, mobipocket and any other future backend that uses TextDocumentGenerator.
    
    I think it may make more sense if you add it in the "backend specific" configuration pages in addPages() like the spectre backend does.
    
    The naming still needs to be good, not sure i can think of one now. Anyone has ideas?


- Albert Astals Cid


On Feb. 19, 2013, 9:41 p.m., Azat Khuzhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109021/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 9:41 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Development history:
> https://github.com/azat/okular/compare/master...font-selector-for-plain-text-formats
> 
> Link to thread from mailing list:
> http://comments.gmane.org/gmane.comp.kde.devel.okular/13279
> 
> 
> Diffs
> -----
> 
>   conf/dlggeneralbase.ui f2c9efd 
>   conf/okular_core.kcfg 054b5c1 
>   core/textdocumentgenerator.h dd75c5c 
>   core/textdocumentgenerator.cpp f370ded 
>   core/textdocumentgenerator_p.h 749d6f2 
> 
> Diff: http://git.reviewboard.kde.org/r/109021/diff/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Azat Khuzhin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130219/747cb280/attachment.html>