[Okular-devel] Txt backend for okular, for plain text files.

Sun Feb 17 23:27:25 UTC 2013

On Feb 18, 2013 2:45 AM, "Albert Astals Cid" <aacid at kde.org> wrote:
>
> El Divendres, 15 de febrer de 2013, a les 00:45:10, Azat Khuzhin va
escriure:
> > Here is simple version of font selector for plain text formats.
> > (Formats based on TextDocumentGenerator.)
> >
> > It works only if you installing custom font before document loaded.
>
> Not sure what you mean with this sentence

It was already fixed. You can see git history for more info.

>
> >
> >
https://github.com/azat/okular/compare/master...font-selector-for-plain-text
> > -formats
>
> Lol, you are closing and opening the document, seems a bit extreme :D

I did this because we need do update all pages. So why not?
But it was is a _hack_. Can you suggest better decision?

But we need to reopen only text documents. I will fix this in the next few
days.

>
> >
> > I also can push this patch to git.reviewboard.kde.org if this will be
> > more comfortable.
>
> It's easier for us to review and keep track of the missing things to
review.
>
> Cheers,
>   Albert
>
> >
> > On Thu, Feb 14, 2013 at 10:41 AM, Azat Khuzhin <dohardgopro at gmail.com>
> wrote:
> > > Hi Albert,
> > >
> > > Thanks, I forgot about that places.
> > > Fixed.
> > >
> > > Maybe I need to push this patch to git.reviewboard.kde.org ?
> > >
> > > On Thu, Feb 14, 2013 at 3:08 AM, Albert Astals Cid <aacid at kde.org>
wrote:
> > >> El Dijous, 14 de febrer de 2013, a les 01:15:39, Azat Khuzhin va
> escriure:
> > >>> Hi all,
> > >>>
> > >>> I found Okular::TextDocumentGenerator, so I fully rewrite current
txt
> > >>> backend using Okular::TextDocumentGenerator
> > >>> And code become pretty clear now.
> > >>>
> > >>> Patch available here
> > >>>
https://github.com/azat/okular/compare/master...add-txt-support.patch
> > >>>
> > >>> Human view here
> > >>> https://github.com/azat/okular/compare/master...add-txt-support
> > >>
> > >> Document::toUnicode will crash if the prober doesn't give you enough
> > >> confidence and you return "" in detectEncoding
> > >>
> > >> Also i don't see why you need to cache m_detectedEncoding since
toUnicode
> > >> is only called from the document constructor.
> > >>
> > >> Cheers,
> > >>
> > >>   Albert
> > >>>
> > >>> New screenshot available here:
> > >>> http://i.imgur.com/YZEmlg0.png
> > >>>
> > >>> Any wishes?
> > >>>
> > >>> On Wed, Feb 13, 2013 at 8:48 AM, Azat Khuzhin <dohardgopro at gmail.com
>
> wrote:
> > >>> > On Wed, Feb 13, 2013 at 3:06 AM, Albert Astals Cid <aacid at kde.org>
> wrote:
> > >>> >> El Dilluns, 11 de febrer de 2013, a les 11:14:33, Azat Khuzhin va
> > >>
> > >> escriure:
> > >>> >>> On Mon, Feb 11, 2013 at 1:15 AM, Albert Astals Cid <
aacid at kde.org>
> > >>
> > >> wrote:
> > >>> >>> > El Diumenge, 10 de febrer de 2013, a les 21:34:35, Azat
Khuzhin va
> > >>> >>
> > >>> >> escriure:
> > >>> >>> >> Hi all,
> > >>> >>> >
> > >>> >>> > Hi
> > >>> >>> >
> > >>> >>> >> I write simple plain text backend for okular.
> > >>> >>> >> https://github.com/azat/okular/tree/add-txt-support
> > >>> >>> >
> > >>> >>> > To be honest i don't see what benefit a plain text backend for
> > >>> >>> > okular
> > >>> >>> > has,
> > >>> >>> > but I'm not going to try to stop you :-)
> > >>> >>>
> > >>> >>> I use okular to read books, and I have one book in plaintext
format,
> > >>> >>> but kate doesn't the best choice to read books, so I start
> > >>> >>> implementing this backend.
> > >>> >>
> > >>> >> Makes sense, do you have a screenshot we can see how it is
looking
> > >>> >> like?
> > >>> >
> > >>> > http://i.imgur.com/gX0DEJJ.png
> > >>> > Is this enough?
> > >>> >
> > >>> >> One of the things i think you'll need to implement is a font
> > >>> >> selector,
> > >>> >> no? So you can change font size, etc. That's one of the things
we've
> > >>> >> been needing for lots of other "text based" formats, so it'd be
cool
> > >>> >> to
> > >>> >> get globally :-)>
> > >>> >
> > >>> > Good idea.
> > >>> > I will do this in the next week. More likely after some
> > >>> > refactoring/improvements of new plain text backend.
> > >>> >
> > >>> >>> >> I will support this backend until bringing it to a normal
state.
> > >>> >>> >> It means I will resolv many TODO's in this code, that I
left, and
> > >>> >>> >> do
> > >>> >>> >> some refactoring.
> > >>> >>> >>
> > >>> >>> >> And after some fixes, from time to time, to this backed will
> > >>> >>> >> write
> > >>> >>> >> email to this mail list that new version is available.
> > >>> >>> >>
> > >>> >>> >> It will be great if this backend can be merged to upstream,
for
> > >>> >>> >> everybody.
> > >>> >>> >> So if anybody can tell what must be fixed before merging to
> > >>> >>> >> upstream,
> > >>> >>> >> I will do it as soon as I can.
> > >>> >>> >>
> > >>> >>> >> Patch available here
> > >>> >>> >>
https://github.com/azat/okular/compare/master...add-txt-support.p
> > >>> >>> >> atch
> > >>> >>> >>
> > >>> >>> >> Graphic view available here
> > >>> >>> >>
https://github.com/azat/okular/compare/master...add-txt-support
> > >>> >>> >
> > >>> >>> > Any reason this is happening in github instead of in
git.kde.org?
> > >>> >>> > You'll
> > >>> >>> > probably get more help/visibility if in git.kde.org than in
github
> > >>> >>>
> > >>> >>> I use github for open source development.
> > >>> >>> It doesn't take much to push to git.kde.org too.
> > >>> >>>
> > >>> >>>ceil
> > >>> >>>
> > >>> >>> I'v registered at identity.kde.org and now I have git.kde.org
> > >>> >>> account.
> > >>> >>> But I don't know how can I create repository there.
> > >>> >>> Could you help me with this?
> > >>> >>
> > >>> >> Sadly you can't, you need a "contributor account" and for that
there
> > >>> >> is a
> > >>> >> requirement you have contributed some patches before getting the
> > >>> >> account,
> > >>> >> so i guess for now you'll still need to be in github, sorry for
the
> > >>> >> incorrect information :-/
> > >>> >
> > >>> > Don't worry, I will use github.
> > >>> > I will push to new repository when I will get "contributor
account".
> > >>> >
> > >>> >> Cheers,
> > >>> >>
> > >>> >>   Albert
> > >>> >>
> > >>> >>> > Cheers,
> > >>> >>> >
> > >>> >>> >   Albert
> > >>> >>> >>
> > >>> >>> >> P.S. I will gladly except you help with development.
> > >>> >>> >>
> > >>> >>> >> --
> > >>> >>> >> Azat Khuzhin
> > >>> >>> >> Primary email: a3at.mail at gmail.com
> > >>> >>> >> _______________________________________________
> > >>> >>> >> Okular-devel mailing list
> > >>> >>> >> Okular-devel at kde.org
> > >>> >>> >> https://mail.kde.org/mailman/listinfo/okular-devel
> > >>> >>> >
> > >>> >>> > _______________________________________________
> > >>> >>> > Okular-devel mailing list
> > >>> >>> > Okular-devel at kde.org
> > >>> >>> > https://mail.kde.org/mailman/listinfo/okular-devel
> > >>> >>>
> > >>> >>> --
> > >>> >>> Azat Khuzhin
> > >>> >>> Primary email: a3at.mail at gmail.com
> > >>> >>> _______________________________________________
> > >>> >>> Okular-devel mailing list
> > >>> >>> Okular-devel at kde.org
> > >>> >>> https://mail.kde.org/mailman/listinfo/okular-devel
> > >>> >>
> > >>> >> _______________________________________________
> > >>> >> Okular-devel mailing list
> > >>> >> Okular-devel at kde.org
> > >>> >> https://mail.kde.org/mailman/listinfo/okular-devel
> > >>> >
> > >>> > --
> > >>> > Azat Khuzhin
> > >>> > Primary email: a3at.mail at gmail.com
> > >>>
> > >>> --
> > >>> Azat Khuzhin
> > >>> Primary email: a3at.mail at gmail.com
> > >>> _______________________________________________
> > >>> Okular-devel mailing list
> > >>> Okular-devel at kde.org
> > >>> https://mail.kde.org/mailman/listinfo/okular-devel
> > >>
> > >> _______________________________________________
> > >> Okular-devel mailing list
> > >> Okular-devel at kde.org
> > >> https://mail.kde.org/mailman/listinfo/okular-devel
> > >
> > > --
> > > Azat Khuzhin
> > > Primary email: a3at.mail at gmail.com
> >
> > --
> > Azat Khuzhin
> > Primary email: a3at.mail at gmail.com
> > _______________________________________________
> > Okular-devel mailing list
> > Okular-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/okular-devel
> _______________________________________________
> Okular-devel mailing list
> Okular-devel at kde.org
> https://mail.kde.org/mailman/listinfo/okular-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130218/d489db87/attachment.html>