[Okular-devel] Review Request 108958: Use cached KStatefulBrushes in sidebar list delegate

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108958/#review27500
-----------------------------------------------------------


Just found the link to this review request in bug 315061. I can't comment on whether this approach is suitable for Okular, but here is one idea: Couldn't one make it a bit simpler by using QScopedPointer? This would remove the need to delete manually. You would just have to use QScopedPointer::reset() to assign the pointers in SidebarDelegate::updateBrushCache().

- Frank Reininghaus


On Feb. 14, 2013, 1:20 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108958/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2013, 1:20 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Port the sidebar list delegate to using cached KStatefulBrushes. The cache is invalidated on global color scheme changes. This avoids instanciating a KColorScheme on every paint.
> 
> 
> Diffs
> -----
> 
>   ui/sidebar.h f3f5ebd 
>   ui/sidebar.cpp a73779d 
> 
> Diff: http://git.reviewboard.kde.org/r/108958/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130215/4c50609e/attachment.html>