[Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener

Albert Astals Cid aacid at kde.org
Tue Dec 31 14:53:27 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114754/#review46501
-----------------------------------------------------------


any reason you've implemented the custom key event handler instead of implementing it in slotReturnPressed (as it seems to me that shit+return also invokes it?)

- Albert Astals Cid


On Dec. 31, 2013, 2:19 p.m., Saheb Preet Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114754/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2013, 2:19 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Kevin Funk.
> 
> 
> Bugs: 328576
>     http://bugs.kde.org/show_bug.cgi?id=328576
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> 
> okular do not have a shortcut for searching previous word using shift + enter
> 
> 
> Added a key event listener to the SearchLineEdit class for shift+return.
> 
> 
> Diffs
> -----
> 
>   ui/searchlineedit.h 63ff496 
>   ui/searchlineedit.cpp 31be8fb 
> 
> Diff: https://git.reviewboard.kde.org/r/114754/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20131231/b7dea6df/attachment.html>


More information about the Okular-devel mailing list