[Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

[Jaan Vajakas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112135/
-----------------------------------------------------------

(Updated Aug. 31, 2013, 6:13 a.m.)


Review request for Okular.


Changes
-------

I added some tests. For one test (SearchTest::testNextAndPrevious()) I also added two PDF files and one DJVU file because it seemed for a moment that it would be nice to also test the behavior of Document::searchText (I used the existing SearchTest::test311232() as example), but maybe that was an overkill and it would be enough to only test TextPage::findText with TextPage objects constructed in memory.


Description
-------

This patch solves Bug 323262 and Bug 323263. I also refactored and simplified the code a little. By removing unnecessary calls to toLower in TextPagePrivate::findTextInternalForward and TextPagePrivate::findTextInternalBackward I also fixed a small bug: the letter capital I with dot above (U+0130) did not match itself in case-insensitive mode on Qt 4.8.4 (U+0130 still does not match lowercase i (U+0069), which can be considered another bug, that I didn't fix (although this behavior conforms to the Unicode case folding rules)). 

(I did not implement the Knuth-Morris-Pratt algorithm that I promised in a comment of Bug 323263 because on second thought I find that the win, if any, would probably be negligible except for some very special documents and special query strings.)


This addresses bugs 323262 and 323263.
    http://bugs.kde.org/show_bug.cgi?id=323262
    http://bugs.kde.org/show_bug.cgi?id=323263


Diffs (updated)
-----

  core/textpage.cpp 855942d 
  core/textpage_p.h 8ecf0c9 
  tests/data/a_ba_b.djvu PRE-CREATION 
  tests/data/abab.pdf PRE-CREATION 
  tests/data/abababa.pdf PRE-CREATION 
  tests/searchtest.cpp 495107d 

Diff: http://git.reviewboard.kde.org/r/112135/diff/


Testing
-------


File Attachments (updated)
----------------

tests/data/a_ba_b.djvu
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/a_ba_b.djvu
tests/data/abab.pdf
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/abab.pdf
tests/data/abababa.pdf
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/abababa.pdf


Thanks,

Jaan Vajakas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130831/26c7728f/attachment-0001.html>