[Okular-devel] Review Request 111782: Okular active: Do not position pages on non-exact pixel boundaries

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111782/
-----------------------------------------------------------

(Updated Aug. 18, 2013, 9:07 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Description
-------

As Marco Martin discovered, at some zoom levels on my laptop okular active tries to draw page pixmaps at non-exact pixel boundaries, resulting in almost unreadable text (see attached video).

This patch fixes the issue by rounding the page position to the nearest pixel. Unfortunately, this patch also seems introduce a binding loop:
  QML PageItem_QML_18: Binding loop detected for property "x"

I'm creating this review request as remainder for further investigation.


Diffs
-----

  active/app/package/contents/ui/FullScreenDelegate.qml ac308aa 

Diff: http://git.reviewboard.kde.org/r/111782/diff/


Testing
-------


File Attachments
----------------

Screen recording of the issue
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/screen-recording.ogv


Thanks,

Fabio D'Urso

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130818/f0f9193b/attachment.html>