[Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

Jaydeep Solanki jaydp17 at gmail.com
Sat Aug 17 21:44:36 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111681/#review38048
-----------------------------------------------------------



core/textdocumentgenerator.cpp
<http://git.reviewboard.kde.org/r/111681/#comment28138>

    This isn't necessary, after clicking a link, the images aren't going to update. So, if it is never going to be displayed, it's better not to write it.


- Jaydeep Solanki


On Aug. 17, 2013, 2:28 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111681/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 2:28 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> As indicated in bug 322547, some documents do not specify a text color, and probably assume the default text color to be black. QTextDocument, however, defaults to using the system text color.
> 
> This patch changes the default text color to Qt::black. It should affect epub, fb2, odt, and plain text generators.
> 
> I think it is better to use this approach instead of changing the paper color to use the system background color (see bug 253583), because
> 
> 1) the document might specify a text color in some places,
> 
> 2) the user is able to change the fg/bg colors anyway using Okular's Accessibility options, and those probably expect black on white.
> 
> 
> This addresses bugs 253583 and 322547.
>     http://bugs.kde.org/show_bug.cgi?id=253583
>     http://bugs.kde.org/show_bug.cgi?id=322547
> 
> 
> Diffs
> -----
> 
>   core/textdocumentgenerator.cpp b260b3f 
> 
> Diff: http://git.reviewboard.kde.org/r/111681/diff/
> 
> 
> Testing
> -------
> 
> I tested the document from bug 322547 comment #3.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130817/fab508f6/attachment.html>


More information about the Okular-devel mailing list