[Okular-devel] Review Request 111410: Selection tool: copy/extract as vector graphic by calling "pdftocairo"

[Thomas Fischer]

> On Aug. 16, 2013, 10:18 p.m., Albert Astals Cid wrote:
> > core/generator.h, line 395
> > <http://git.reviewboard.kde.org/r/111410/diff/6/?file=181596#file181596line395>
> >
> >     Why are these not const anymore?

Constructing an instance of QProcess to run pdftocairo requires passing a non-const QObject pointer and "this" is used. I changed it to creating the instance without a parent.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111410/#review38002
-----------------------------------------------------------


On Aug. 16, 2013, 9:17 p.m., Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111410/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2013, 9:17 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch implements the feature request of bug 321350: if a PDF file is viewed, the selection tool offers the new extraction method "vector" which allows to save to a file (PDF, SVG, EPS, PostScript). The crop operation is performed by calling "pdftocairo" with matching arguments. The resulting file contains the original PDF file's content without rendering it to a pixmap.
> 
> I am not sure if calling an external program is an acceptable solution for this problem. However, it is tested if the program is available before showing the new option. Alternatively, the code of pdftocairo (as part of poppler) would had to be copied and integrated into Okular increasing the solution's complexity. I am not aware of a similar solution available using poppler-qt4 only. Maybe using a QPrinter printing to PDF would have been an alternative, but again this seemed to be too complex.
> 
> 
> Diffs
> -----
> 
>   core/document.h fe296e0 
>   core/document.cpp 3af92c8 
>   core/generator.h a5a971b 
>   core/generator.cpp 41beb92 
>   generators/poppler/generator_pdf.h 5d5853a 
>   generators/poppler/generator_pdf.cpp 1a44523 
>   ui/pageview.cpp 5944072 
> 
> Diff: http://git.reviewboard.kde.org/r/111410/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130817/ce85d36e/attachment-0001.html>