[Okular-devel] Review Request 110003: Best-fit zoom

[Albert Astals Cid]

> On Aug. 14, 2013, 9:55 p.m., Albert Astals Cid wrote:
> > "Second, I am trying to add "Auto Fit" as one of the default zoom settings in the configuration dialog. Although I was quite sure I did not miss a spot and the option turns up in the settings dialog, choosing "Auto Fit" does not get activated when restarting Okular. Any hints what goes wrong?"
> > 
> > You aware this setting only applies for files you've never opened? Is this your problem?
> 
> Thomas Fischer wrote:
>     Indeed. I tested it with another file I had never opened before and AutoFit was active as expected.
>     So, is there anything left or is my patch good to be accepted?

Looks ok from the code POV (well you need to update part.rc version and adding a few const to variables that never change like uiAspect/pageAspect/etc would be cool)

What I would like you is editing the docbook manual to explain the new zoom mode. Can you do that?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110003/#review37805
-----------------------------------------------------------


On July 7, 2013, 11:04 p.m., Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110003/
> -----------------------------------------------------------
> 
> (Updated July 7, 2013, 11:04 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Attached patch implements best-fit zoom for Okular. It is a refined version of the patch submitted in bug report 249364, attachment 51069. The refinement addresses the scrollbar issues as observed in continuous view mode.
> 
> 
> This addresses bug 249364.
>     http://bugs.kde.org/show_bug.cgi?id=249364
> 
> 
> Diffs
> -----
> 
>   conf/dlggeneralbase.ui f2c9efd 
>   conf/okular.kcfg 1e23d61 
>   part.rc 64aeffb 
>   ui/pageview.h 5484cc5 
>   ui/pageview.cpp 16b00ab 
> 
> Diff: http://git.reviewboard.kde.org/r/110003/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130816/041f1b72/attachment-0001.html>