[Okular-devel] Review Request 109627: Outline based selection for annotation elements

[Albert Astals Cid]

> On March 21, 2013, 11:22 p.m., Albert Astals Cid wrote:
> > core/area.h, line 28
> > <http://git.reviewboard.kde.org/r/109627/diff/1/?file=120762#file120762line28>
> >
> >     Don't think this belongs to area.h to be honest
> 
> Peter Grasch wrote:
>     Would you prefer something like this:
>     bool ObjectRect::boundedContains( double x, double y, double xScale, double yScale ) const
>     
>     I don't really use the constant for anything other than that except for the eraser but - if that were to be extended for a configurable brush size - that would need to be changed anyway.

What I basically don't like is that you've added it to a public header, since you are only using it in page.cpp put it there for the moment and we'll see how to export it out if/when we need it.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109627/#review29666
-----------------------------------------------------------


On March 23, 2013, 7:52 p.m., Peter Grasch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109627/
> -----------------------------------------------------------
> 
> (Updated March 23, 2013, 7:52 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Multiple features in Okular require to determine what object is at a given position. Traditionally, this relied on the bounding boxes of the given object.
> These do not necessarily correlate with the user would expect (for example, a diagonal line of 1px has a very large bounding box).
> 
> This patch implementes shape based selection for the following annotation types:
> Ink, Geometric, Line, Highlight.
> Other objects default to the old behaviour.
> 
> 
> Diffs
> -----
> 
>   core/annotations.h 72abdff 
>   core/annotations.cpp 49ab5bd 
>   core/annotations_p.h 221572d 
>   core/area.h 4f63759 
>   core/area.cpp d772fc0 
>   core/page.cpp 1db2763 
>   tests/CMakeLists.txt 6a26b3e 
>   tests/annotationstest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109627/diff/
> 
> 
> Testing
> -------
> 
> I tested the annotation objects above and a couple of special cases mentioned in the IRC.
> 
> 
> Thanks,
> 
> Peter Grasch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130404/281a85f3/attachment.html>