[Okular-devel] Review Request 107442: Add undo/redo support for annotations

[Jon Mease]

> On April 3, 2013, 9:16 p.m., Albert Astals Cid wrote:
> > I was about to commit and then i saw we still have the m_prevAnnotTextCursorPos and m_prevAnnotTextAnchorPos maps. Do we really need them? As far as I can see they only get used to fill the commands for the AnnotWindow, can't we cache "old" those values to feed the command in AnnotWindow itself?

Do you mean have the annotWindow keep track of its own previous cursor and anchor positions and then pass them in as arguments along with the annotation's new contents? If so I believe I already implemented this approach in a previous version of the patch so it won't be hard to dig it back up again.
Thanks


- Jon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107442/#review30337
-----------------------------------------------------------


On March 27, 2013, 12:10 p.m., Jon Mease wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107442/
> -----------------------------------------------------------
> 
> (Updated March 27, 2013, 12:10 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch adds undo/redo support to Okular's annotation manipulation commands.
> 
> Functionality:
> The following actions can be undone and redone: creation and removal of annotations, editing arbitrary annotation properties, relocating annotations with Ctrl+drag, and editing the text contents of an annotation.
> 
> This patch does not include support for undoing and redoing editing actions on forms.
> 
>   
> 
> 
> This addresses bug 177501.
>     http://bugs.kde.org/show_bug.cgi?id=177501
> 
> 
> Diffs
> -----
> 
>   core/annotations.h 72abdff 
>   core/annotations.cpp 49ab5bd 
>   core/annotations_p.h 221572d 
>   core/document.h 6ff6536 
>   core/document.cpp 5ab759e 
>   core/document_p.h fb3aec6 
>   core/page.cpp 1db2763 
>   part.rc 39c1571 
>   ui/annotationpropertiesdialog.cpp 4b02258 
>   ui/annotwindow.h f7df9f6 
>   ui/annotwindow.cpp c1bafb9 
>   ui/guiutils.h 2ae4ab3 
>   ui/guiutils.cpp 1d67d3a 
>   ui/pageview.cpp b018dfe 
> 
> Diff: http://git.reviewboard.kde.org/r/107442/diff/
> 
> 
> Testing
> -------
> 
> I have tested the undoing and redoing of the specified annotation actions using .dvi and .pdf documents.
> 
> 
> Thanks,
> 
> Jon Mease
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130404/065016be/attachment.html>