[Okular-devel] Review Request: Make VideoWidget independent of associated annotation type

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106606/#review19583
-----------------------------------------------------------

Ship it!


Works for me

- Albert Astals Cid


On Sept. 27, 2012, 1:45 p.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106606/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2012, 1:45 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Since in a following patch we want to use the VideoWidget to play movies from MovieAnnotations and ScreenAnnotations (with MediaRenditions), this patch makes the API of VideoWidget a bit more generic to only depend on Okular::Movie and Okular::Annotation but no specific subclass.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 496abdc 
>   ui/presentationwidget.cpp 9ba942b 
>   ui/videowidget.h f5d22b9 
>   ui/videowidget.cpp 3d7ebab 
> 
> Diff: http://git.reviewboard.kde.org/r/106606/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120929/d9718219/attachment-0001.html>