[Okular-devel] Review Request: Add RenditionAction class

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106603/#review19579
-----------------------------------------------------------



core/action.h
<http://git.reviewboard.kde.org/r/106603/#comment15568>

    You miss the 0.16 here



core/action.h
<http://git.reviewboard.kde.org/r/106603/#comment15572>

    The docu seems a bit weird, says "if no movie object is set" but we can't set it (only on construction time). Maybe reword to "was set on construction time" or soemthing like that?



core/action.cpp
<http://git.reviewboard.kde.org/r/106603/#comment15569>

    Why is it always play? Shouldn't we consider the pause, etc stuff?


- Albert Astals Cid


On Sept. 27, 2012, 1:29 p.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106603/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2012, 1:29 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch adds a new RenditionAction class which represents the 'Rendition' action from the PDF specification.
> Instead of a MediaRendition object, it provides an Okular::Media object, so that the playback code can be shared.
> 
> 
> Diffs
> -----
> 
>   core/action.h cdf4c96 
>   core/action.cpp d65f8e0 
> 
> Diff: http://git.reviewboard.kde.org/r/106603/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120929/5320d55b/attachment.html>