[Okular-devel] Review Request: Create proper Okular::ScreenAnnotation objects in poppler generator

[Tobias Koenig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106605/
-----------------------------------------------------------

(Updated Sept. 27, 2012, 1:41 p.m.)


Review request for Okular.


Changes
-------

Add missing patch ;)


Description
-------

This patch requires the patch from https://bugs.freedesktop.org/show_bug.cgi?id=55378 to be comitted to poppler first.
It creates proper Okular::ScreenAnnotation objects and setups their trigger action. Since a RenditionAction object can reference a ScreenAnnotation, the references are resolved the same way we did it for the MovieAction/MovieAnnotation pairs. So the resolveMovieLinkReference() method has been renamed to resolveMediaLinkReference() to match the functional change.


Diffs (updated)
-----

  generators/poppler/annots.cpp 02813a1 
  generators/poppler/generator_pdf.h bea65d9 
  generators/poppler/generator_pdf.cpp fcc8dc4 

Diff: http://git.reviewboard.kde.org/r/106605/diff/


Testing
-------


Thanks,

Tobias Koenig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120927/a00217bb/attachment.html>