[Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

Bogdan Cristea cristeab at gmail.com
Wed Sep 26 20:25:35 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104947/
-----------------------------------------------------------

(Updated Sept. 26, 2012, 8:25 p.m.)


Review request for Okular.


Changes
-------

Fixed issue related to settings update with kconf_update. Also added observer.h to the list of installed (public) headers.


Description
-------

Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files:
-okular.kcfg (front end)
-okular_core.kcfg (back end)


Diffs (updated)
-----

  CMakeLists.txt a057e82 
  conf/okular.kcfg 9174733 
  conf/okular_core.kcfg PRE-CREATION 
  conf/settings.kcfgc 0b70390 
  conf/settings_core.kcfgc PRE-CREATION 
  core/document.cpp 7f006e6 
  core/script/kjs_fullscreen.cpp c07ac4e 
  core/texteditors_p.h 171dc69 
  okular.upd PRE-CREATION 
  ui/pagepainter.cpp 537e5c5 
  ui/pageview.cpp 496abdc 
  ui/presentationwidget.cpp 9ba942b 

Diff: http://git.reviewboard.kde.org/r/104947/diff/


Testing
-------

No


Thanks,

Bogdan Cristea

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120926/38ff61e2/attachment-0001.html>


More information about the Okular-devel mailing list