[Okular-devel] Review Request: D-Bus access to non-first Okular::Part

[Albert Astals Cid]

> On Sept. 22, 2012, 7:35 a.m., Albert Astals Cid wrote:
> > What's this supposed to do?
> 
> Jaydeep Solanki wrote:
>     It registers the Okular::Part with "/okularX" where X will be incremented..
>     So every part can be accessed..
>     Actually it would be nice, if you can apply the patch & see what it is doing :)

Really? How does an if condition do that?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106531/#review19281
-----------------------------------------------------------


On Sept. 21, 2012, 11:05 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106531/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2012, 11:05 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This is just a rough change, I just want to confirm if I'm going in the right direction.
> Once you confirm it, I'll clean up the code..
> 
> I guess it's not perfect, but manages to connect with the non first Okular::Part.
> 
> 
> This addresses bug 306313.
>     http://bugs.kde.org/show_bug.cgi?id=306313
> 
> 
> Diffs
> -----
> 
>   part.cpp fe11189 
> 
> Diff: http://git.reviewboard.kde.org/r/106531/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120922/4a3d7a37/attachment.html>