[Okular-devel] Review Request: Implement the handling of page rotations for source references

Michel Ludwig michel.ludwig at gmail.com
Tue Sep 18 21:08:56 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103060/
-----------------------------------------------------------

(Updated Sept. 18, 2012, 9:08 p.m.)


Review request for Okular.


Changes
-------

The corner cases I was referring to are when you drag the mouse around on the thumbnail widget such that the current page is changed (also in different zoom modes).

The code for rotated pages seems to work as well as the one did for Rotation0 ;)


Description
-------

Implement the handling of page rotations for source references.


Diffs (updated)
-----

  core/document.h 85cd821 
  core/document.cpp 9d6b25c 
  core/page.h a8f2761 
  core/page.cpp d746382 
  core/utils.h 8d5d5fc 
  core/utils.cpp 5dd8448 
  generators/dvi/generator_dvi.cpp 5cd327f 
  generators/poppler/generator_pdf.cpp c63753e 
  part.cpp fe11189 
  ui/pagepainter.cpp 537e5c5 
  ui/pageview.h 8cf8844 
  ui/pageview.cpp d3e1888 
  ui/side_reviews.cpp a35f9ed 
  ui/thumbnaillist.cpp 60288cb 

Diff: http://git.reviewboard.kde.org/r/103060/diff/


Testing
-------


Thanks,

Michel Ludwig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120918/2d65f9c8/attachment.html>


More information about the Okular-devel mailing list