[Okular-devel] Review Request: Added warning if using --unique but open more than one document

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106476/#review19120
-----------------------------------------------------------



shell/main.cpp
<http://git.reviewboard.kde.org/r/106476/#comment15194>

    Don't use kWarning, use a QTextStream over stdout or stderr as you prefer



shell/main.cpp
<http://git.reviewboard.kde.org/r/106476/#comment15195>

    This is actually not a "clean" exit, so don't return 0, return -1


- Albert Astals Cid


On Sept. 18, 2012, 8:03 a.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106476/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2012, 8:03 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> When using more than one terminal instances to open, more than one -unique Okular instances, it informs the user that only one unique instance can exist.
> & when using the open action, Okular refuses to open another instance, because there can be only one unique instance.
> 
> Open for suggestions :)
> 
> 
> This addresses bug 306312.
>     http://bugs.kde.org/show_bug.cgi?id=306312
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp 84e9406 
>   shell/shell.cpp db38357 
> 
> Diff: http://git.reviewboard.kde.org/r/106476/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120918/c9395418/attachment.html>