[Okular-devel] Review Request: Add option to show complete file path in document title

[Albert Astals Cid]

> On Sept. 6, 2012, 6:42 p.m., Albert Astals Cid wrote:
> > But then you have an option that says:
> >  * Display full path in title bar
> >  * Display title if available
> > And I have both checked.
> > 
> > What do I get? (i know what i get, but what would a user expect?)
> > 
> > Not sure a combobox is a great idea but at least doesn't have this ambiguity, maybe whatsthis/Tooltip would be enough?

Maybe two radio buttons and a label after the 
* Display title if available
checkbox that say
When not showing document title show [] File Path [] File Name
?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106345/#review18635
-----------------------------------------------------------


On Sept. 5, 2012, 11:54 p.m., Sandro Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106345/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2012, 11:54 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Add option to show complete file path in document title
> 
> 
> This addresses bug 296870.
>     http://bugs.kde.org/show_bug.cgi?id=296870
> 
> 
> Diffs
> -----
> 
>   conf/dlggeneralbase.ui c167b350555b13ff9db873efb64d8b48afd8d1d4 
>   conf/okular.kcfg 6ad0e192bff1cd93f7f23590fbea8fdd309b7820 
>   part.cpp 2808083af9c50d934b72fdd3c2a7e11f024c9383 
> 
> Diff: http://git.reviewboard.kde.org/r/106345/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Mani
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120906/b61f85af/attachment.html>