[Okular-devel] Review Request: Settings separation: observer.h install and compilation correction on Windows

[Bogdan Cristea]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107047/
-----------------------------------------------------------

(Updated Oct. 26, 2012, 7:57 a.m.)


Review request for Okular.


Changes
-------

corrected exported symbol in okular_part_export.h for Unix


Description
-------

This patch is related to settings separation for the frontend and the backend. It proposes the installation of core/observer.h and corrects compilation of okular on Windows (using KDE on windows):
- after separation, settings.h and settings_core.h need to use different precompiler switches for exporting/importing symbols
- add definitions needed to activate these switches on Windows


Diffs (updated)
-----

  CMakeLists.txt 063778f 
  active/components/CMakeLists.txt 19b759e 
  conf/settings.kcfgc 5e2ec95 
  okular_part_export.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107047/diff/


Testing
-------

yes


Thanks,

Bogdan Cristea

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121026/424fb06c/attachment-0001.html>