[Okular-devel] Review Request: Use libffmpegthumbnailer to create first-frame images in SnapshotTaker

[Albert Astals Cid]

> On Oct. 8, 2012, 8:53 p.m., Albert Astals Cid wrote:
> > Does it have to be the ffmpegthumbnailer specifically? Afaik there's another video thumbnailer around, isn't there a generic kde mechanism to ask for the installed video thumbnailer and use that one?
> 
> Tobias Koenig wrote:
>     Hej Albert,
>     
>     the thumbnailer KIO slave is more or less about creating thumbnails of general files. We need to take a screenshot of a specific frame inside a video here, so we can't use the general framework. I just picked the ffmpegthumbnailer since it has a simply API and seems to be shipped by all distributions. We can add an abstraction layer later on of course if somebody wants to use another thumbnailer (or better say frameshot taker)

:-/

Does the ffmpegthumbnailer guarantee they won't change the API too much? Can you add a macro_log_feature to the cmake stuff?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106761/#review20102
-----------------------------------------------------------


On Oct. 8, 2012, 8:48 a.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106761/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2012, 8:48 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> In the old implementation the Phonon::VideoWidget::snapshot() method was used to create the first-frame (poster) images for a movie, however the Phonon API and the backends (gstreamer and vlc) provide no reliable way to take the snapshot of the first frame. For this reason this patch adds an additional option to use the libffmpegthumbnailer library to take the snapshot of the first frame.
> It is faster than using the VideoWidget::snapshot() method and always returns the requested frame.
> 
> 
> Diffs
> -----
> 
>   ui/CMakeLists.txt b80c447 
>   ui/config-snapshot-method.h.cmake PRE-CREATION 
>   ui/snapshottaker.h e34c3e0 
>   ui/snapshottaker.cpp 362d249 
>   CMakeLists.txt a057e82 
>   cmake/modules/FindFfmpegThumbnailer.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106761/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121022/21181a4d/attachment.html>