[Okular-devel] Review Request: Support high precision Wacom input for creating annotations

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106816/#review20318
-----------------------------------------------------------


Looks great! Please have a look to the small comments inline in the code


ui/annotationtools.h
<http://git.reviewboard.kde.org/r/106816/#comment16059>

    You don't need this in here, just forward declare the QTabletEvent (if that's why you added this include)



ui/annotationtools.cpp
<http://git.reviewboard.kde.org/r/106816/#comment16060>

    Can you fix the extra spacing (red stuff marked in red in the reviewboard)



ui/annotationtools.cpp
<http://git.reviewboard.kde.org/r/106816/#comment16061>

    Please move this to a swtich 



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/106816/#comment16062>

    statics are evil, do you really need penDown to be static?



ui/pageviewannotator.cpp
<http://git.reviewboard.kde.org/r/106816/#comment16063>

    I know we don't do it in the old code, but it'd be cool if you could add const to the variables you set in the "definition line" and are not meant to be modified again


- Albert Astals Cid


On Oct. 12, 2012, 10:03 p.m., Jon Mease wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106816/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2012, 10:03 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch adds processing of QTabletEvents to the PageView class. Basically a graphics tablet will behave exactly like a mouse except while creating an annotation. When creating an annotation, the higher precision position of the QTabletEvent is used and this results in smoother free-hand annotations (See the attached image for a before and after comparison).  With this patch in place it's possible to create a nice looking signature in an Okular document using a graphics tablet.
> 
> 
> Diffs
> -----
> 
>   ui/annotationtools.h 7107042 
>   ui/annotationtools.cpp 40fa6fe 
>   ui/pageview.h c1b36f4 
>   ui/pageview.cpp 2ef10a1 
>   ui/pageviewannotator.h a2ef90d 
>   ui/pageviewannotator.cpp 9754b5e 
> 
> Diff: http://git.reviewboard.kde.org/r/106816/diff/
> 
> 
> Testing
> -------
> 
> * The creation of annotations using the wacom pen (smooth freehand annotations)
> * The creation of annotations using the mouse (no change)
> * The operation of the annotations menu using both the mouse and the wacom pen (pen behaves just like the mouse).
> 
> 
> Thanks,
> 
> Jon Mease
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121014/3369ecb5/attachment-0001.html>