[Okular-devel] Review Request: Use libffmpegthumbnailer to create first-frame images in SnapshotTaker
Tobias Koenig
tokoe at kde.org
Mon Oct 8 08:48:37 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106761/
-----------------------------------------------------------
Review request for Okular.
Description
-------
In the old implementation the Phonon::VideoWidget::snapshot() method was used to create the first-frame (poster) images for a movie, however the Phonon API and the backends (gstreamer and vlc) provide no reliable way to take the snapshot of the first frame. For this reason this patch adds an additional option to use the libffmpegthumbnailer library to take the snapshot of the first frame.
It is faster than using the VideoWidget::snapshot() method and always returns the requested frame.
Diffs
-----
ui/CMakeLists.txt b80c447
ui/config-snapshot-method.h.cmake PRE-CREATION
ui/snapshottaker.h e34c3e0
ui/snapshottaker.cpp 362d249
CMakeLists.txt a057e82
cmake/modules/FindFfmpegThumbnailer.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/106761/diff/
Testing
-------
Thanks,
Tobias Koenig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121008/9f95665b/attachment.html>
More information about the Okular-devel
mailing list