[Okular-devel] Review Request: QML components and touch optimized okular version

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106666/#review19864
-----------------------------------------------------------


Little summary since the other block is getting huge :D

 * Messages.sh tweaking after merge
 * .desktop for format support tweaking after merge
 * Bookmark viewport vs page number
 * Pagepainter API to disable AA

I think we can leave the pagepainter change for after the merge too, not sure about the bookmark thing since it's "public qml API" related, not that we have to promise API stability on the QML side either...

So what do you say, you want to me to merge now or finish the fixup these things?

- Albert Astals Cid


On Oct. 3, 2012, 10:17 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106666/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2012, 10:17 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering)
> 
> Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a057e82 
>   active/CMakeLists.txt PRE-CREATION 
>   active/app/CMakeLists.txt PRE-CREATION 
>   active/app/Messages.sh PRE-CREATION 
>   active/app/active-documentviewer.desktop PRE-CREATION 
>   active/app/package/contents/ui/Bookmarks.qml PRE-CREATION 
>   active/app/package/contents/ui/Browser.qml PRE-CREATION 
>   active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION 
>   active/app/package/contents/ui/TableOfContents.qml PRE-CREATION 
>   active/app/package/contents/ui/Thumbnails.qml PRE-CREATION 
>   active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION 
>   active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION 
>   active/app/package/contents/ui/bookmark.png PRE-CREATION 
>   active/app/package/contents/ui/bookmark.svgz PRE-CREATION 
>   active/app/package/contents/ui/main.qml PRE-CREATION 
>   active/app/package/metadata.desktop PRE-CREATION 
>   active/app/src/CMakeLists.txt PRE-CREATION 
>   active/app/src/main.cpp PRE-CREATION 
>   active/components/CMakeLists.txt PRE-CREATION 
>   active/components/Messages.sh PRE-CREATION 
>   active/components/documentitem.h PRE-CREATION 
>   active/components/documentitem.cpp PRE-CREATION 
>   active/components/okularplugin.h PRE-CREATION 
>   active/components/okularplugin.cpp PRE-CREATION 
>   active/components/pageitem.h PRE-CREATION 
>   active/components/pageitem.cpp PRE-CREATION 
>   active/components/qmldir PRE-CREATION 
>   active/components/thumbnailitem.h PRE-CREATION 
>   active/components/thumbnailitem.cpp PRE-CREATION 
>   active/components/tocmodel.h PRE-CREATION 
>   active/components/tocmodel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106666/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121003/ae051248/attachment.html>