[Okular-devel] Review Request: Activities support for Okular

[Ivan Čukić]

> On Oct. 2, 2012, 6:13 p.m., Albert Astals Cid wrote:
> > Any reason this is at the Document level and not at the Part level? Feels to me it belongs more into the part than the document.
> 
> Ivan Čukić wrote:
>     This is really meant to be a document-link (Resource == Document most of the time -> thus ResourceInstance is kinda DocumentInstance) with one small peculiarity - the need for the window id because of share-like-connect.
>     
>     The second thing is that, for the directory listing, we might need some special handling* so I didn't want to make it work by reporting the location just yet.
>     
>     * for example, it could report the path the user is browsing, but to report the selected files on request (for share-like-connect)
> 
> Ivan Čukić wrote:
>     Forget the last two paragraphs, meant this is the Gwenview patch review.
> 
> Albert Astals Cid wrote:
>     Sure and Part == Document too, i just don't like it in the document, it adds more "ui" dependencies to the core (which already has a few, but the idea is to have less, not more) and besides if i ever do my "okulartotext" command line program that reads a file with okular and exports as text, it won't have a widget (I know there's lots of things to fix, but i'd like to have one less)

What do you think about putting it even above KPart - tied to the Okular application itself?

After some thought, I've decided sharing parts in this case would produce more issues than it would solve.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106685/#review19772
-----------------------------------------------------------


On Oct. 2, 2012, 4:15 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106685/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 4:15 p.m.)
> 
> 
> Review request for Okular, Plasma and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Okular reports the open/close document events to activity manager daemon.
> Side-effect - support for Share-Like-Connect applet.
> 
> (and some trailing spaces auto-removal)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a057e82 
>   core/document.cpp 143d598 
>   core/document_p.h 91a5577 
> 
> Diff: http://git.reviewboard.kde.org/r/106685/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121002/6f46c5a5/attachment.html>