[Okular-devel] Review Request: Properties dialog: switch to QFormLayout and showing icon for mime type

[Thomas Fischer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107357/
-----------------------------------------------------------

(Updated Nov. 17, 2012, 7:51 p.m.)


Review request for Okular.


Changes
-------

Addressing issues:
- KMimeType::mimeType may return 0, please account for that
- convert the QLatin1String into a i18nc so translators can change the order or the way of showing, maybe () is not usual, if they need it


Description
-------

This patch changes the properties dialog to use QFormLayout instead of a two-column QGridLayout. This should make the dialog more compatible with other user interfaces.
For the mime type row, instead of just showing the mime type's name, a small QLabel is used to show the mime type's icon.

Maybe it would be a good idea to not only show the mime type's name, but also the description (KMimeType::comment(..)). Example: "PDF Document (application/pdf)"


Diffs (updated)
-----

  ui/propertiesdialog.cpp 2ef8220 

Diff: http://git.reviewboard.kde.org/r/107357/diff/


Testing
-------


Screenshots
-----------

QFormLayout and mime type icon
  http://git.reviewboard.kde.org/r/107357/s/835/


Thanks,

Thomas Fischer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121117/b9d74dea/attachment.html>