[Okular-devel] Review Request: GUI to configure the Graphics Anti-alias.

[Jaydeep Solanki]

> On Nov. 14, 2012, 12:26 p.m., Albert Astals Cid wrote:
> > conf/okular_core.kcfg, line 26
> > <http://git.reviewboard.kde.org/r/106660/diff/3/?file=92396#file92396line26>
> >
> >     Why the order change?

because enum stores constants with values (0,1,2,...) starting from the first constant.
We have two constants, Enabled & Disabled, which would be stored as 0 & 1, that's why when I first tried checkboxes it gave me inverted results.
So I just changed the order so that Enabled gets value 1 & Disabled gets value 0, this fixes the inverted checkbox problem and would work the same when changing from terminal as it takes the constant as input.


- Jaydeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106660/#review21979
-----------------------------------------------------------


On Nov. 15, 2012, 8:23 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106660/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2012, 8:23 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Graphics Anti-alias can be enabled/disabled from Okular settings..
> 
> 
> This addresses bug 164759.
>     http://bugs.kde.org/show_bug.cgi?id=164759
> 
> 
> Diffs
> -----
> 
>   conf/dlgperformancebase.ui 3a9f9aa 
>   conf/okular_core.kcfg e807cbc 
> 
> Diff: http://git.reviewboard.kde.org/r/106660/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121115/8be03af8/attachment-0001.html>