[Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

Albert Astals Cid tsdgeos at terra.es
Tue May 15 21:38:09 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104947/#review13868
-----------------------------------------------------------


Why is EnableCompositing in core if it is only used in ui?

- Albert Astals Cid


On May 14, 2012, 5:29 p.m., Bogdan Cristea wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104947/
> -----------------------------------------------------------
> 
> (Updated May 14, 2012, 5:29 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files:
> -okular.kcfg (front end)
> -okular_core.kcfg (back end)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0034cf3 
>   conf/okular.kcfg 6ad0e19 
>   conf/okular_core.kcfg PRE-CREATION 
>   conf/settings_core.kcfgc PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104947/diff/
> 
> 
> Testing
> -------
> 
> No
> 
> 
> Thanks,
> 
> Bogdan Cristea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120515/90d32fdf/attachment-0001.html>


More information about the Okular-devel mailing list