[Okular-devel] Review Request: Use the left/right arrow keys to change the page
Mailson Menezes
mailson at gmail.com
Tue May 1 14:55:40 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104596/#review13211
-----------------------------------------------------------
Just a coding style change.
ui/pageview.cpp
<http://git.reviewboard.kde.org/r/104596/#comment10336>
I think you should add extra spaces inside the 'if' parentheses to keep Okular coding style.
Also the opening bracket should go on the line below.
- Mailson Menezes
On April 18, 2012, 8:26 p.m., Thomas Etter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104596/
> -----------------------------------------------------------
>
> (Updated April 18, 2012, 8:26 p.m.)
>
>
> Review request for Okular and Albert Astals Cid.
>
>
> Description
> -------
>
> If no horizontal scrollbar is visible, change pages using the left/right arrow keys. In facing mode, move two pages per key press.
>
>
> Diffs
> -----
>
> ui/pageview.cpp 4be5e6b
>
> Diff: http://git.reviewboard.kde.org/r/104596/diff/
>
>
> Testing
> -------
>
> Works on my system
>
>
> Thanks,
>
> Thomas Etter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120501/4e041cf5/attachment.html>
More information about the Okular-devel
mailing list