[Okular-devel] Review Request: Remember position on the page in bookmark

[Mailson Menezes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104365/
-----------------------------------------------------------

(Updated March 26, 2012, 3:57 a.m.)


Review request for Okular and Albert Astals Cid.


Changes
-------

Some modifications suggested by Albert

- add some @since markers on new methods documentation
- the function documentViewportLessThan is not a public function from BookmarkManager anymore
- add 2 new member functions: nextBookmark and previousBookmark. those return the next/previous bookmark for a given viewport
- add static declarations to some functions


Description
-------

This feature will remember the position where the user saved a bookmark. Also, will allow the user have multiple bookmarks per page.


This addresses bug 157198.
    http://bugs.kde.org/show_bug.cgi?id=157198


Diffs (updated)
-----

  core/bookmarkmanager.h 21bf34665b6c28877c13e6e8b759e10f76af5305 
  core/bookmarkmanager.cpp 2d9c9c0134720689764c7dd858ea600de757eb3d 
  part.h 1aafe265b7afa5a138aae4c9c0d41305456efff8 
  part.cpp aee1d42ab2c8d30acaec2cd33821523402003a31 

Diff: http://git.reviewboard.kde.org/r/104365/diff/


Testing
-------


Thanks,

Mailson Menezes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120326/427cd801/attachment.html>