[Okular-devel] Review Request: Remember position on the page in bookmark

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104365/#review11774
-----------------------------------------------------------


I've tried the patch, and it appears to work well. Existing bookmarks continue to work, and new bookmarks remember the page position. Renaming bookmarks still works, too. And I agree this is a nice improvement to the bookmarking user experience.

One possible improvement would be to change the default bookmark name to include the position in some way, though.

- Eike Hein


On March 22, 2012, 3:14 p.m., Mailson Menezes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104365/
> -----------------------------------------------------------
> 
> (Updated March 22, 2012, 3:14 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> This feature will remember the position where the user saved a bookmark. Also, will allow the user have multiple bookmarks per page.
> 
> 
> This addresses bug 157198.
>     http://bugs.kde.org/show_bug.cgi?id=157198
> 
> 
> Diffs
> -----
> 
>   core/bookmarkmanager.h 21bf34665b6c28877c13e6e8b759e10f76af5305 
>   core/bookmarkmanager.cpp 2d9c9c0134720689764c7dd858ea600de757eb3d 
>   part.h 1aafe265b7afa5a138aae4c9c0d41305456efff8 
>   part.cpp aee1d42ab2c8d30acaec2cd33821523402003a31 
> 
> Diff: http://git.reviewboard.kde.org/r/104365/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mailson Menezes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120323/a472deef/attachment.html>